v1.2.18 v2: fix #114 as well

This commit is contained in:
Luke S Thompson
2025-10-19 21:13:33 +11:00
parent b860eb7098
commit cd2494d688
7 changed files with 8 additions and 7 deletions

View File

@@ -5,7 +5,7 @@ All notable changes to Proxmox VE for WHMCS will be documented in this file.
https://github.com/The-Network-Crew/Proxmox-VE-for-WHMCS/milestones
## [1.2.18] - 2025-10-19 - _"Client Area detail"_
## [1.2.18] - 2025-10-19 - _"Client Area detail" v2_
### 💅 Polish
- Client Area: Polish the interface numbering, v4/v6
@@ -13,6 +13,7 @@ https://github.com/The-Network-Crew/Proxmox-VE-for-WHMCS/milestones
### 🐛 Bug Fix
- noVNC: Cookie remove 2; router tidy-up; tested OK (#167)
- noVNC: Allow for custom WHMCS install subdirectory (#114)
## [1.2.17] - 2025-10-19 - _"VNC & Hyperscale!"_

View File

@@ -8,7 +8,7 @@
If you have proven and public git-logged experience, or similar, please say g'day.
Please note: We are only looking for high-quality applicants with spare time.
As it stands, we won't have much spare dev time for this Module in 2025.
As it stands, we won't have much spare dev time for this Module in 2025/NY.
- Configure VM/CT plans with custom CPU/RAM/VLAN/On-boot/Bandwidth/etc
- Automatically Provision VMs & CTs in **Proxmox VE** from **WHMCS** easily
@@ -138,8 +138,6 @@ After forking the module, we considered how to improve security of Console Tunne
> Do NOT set less restrictive permissions. The above is designed for interim security.
>
> **However, if you wish for proper security: wait for VNC to be further improved.**
>
> **Note**: Custom WHMCS install folders like /clients/ are not yet VNC-supported. #114
<img alt="Client Area GUI showing the reply which links off to the VNC Console/Client" src="_images/zConsoleReady.png">
@@ -167,6 +165,8 @@ Once you have it configured, clicking noVNC in Client Area provides direct link
>
> Load noVNC with `logging=debug` added to the query string, ie. `vnc.html?logging=debug`<br>
> _Or in Settings change Logging to debug-level, then open JS Console before reloading noVNC._
>
> Typically, 401 No Ticket from PVE (1006 Connection Closed via noVNC) is due to cross-domain attempts being made, ie. WHMCS on domain1.com and PVE on domain2.com. You must use subdomains on the same Domain, with PTR, etc - else it won't work.
## 🌐 3. Networking: IPv4 Pools, IPv6, vmbr/SDN

Binary file not shown.

Before

Width:  |  Height:  |  Size: 119 KiB

After

Width:  |  Height:  |  Size: 287 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 315 KiB

After

Width:  |  Height:  |  Size: 315 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 42 KiB

After

Width:  |  Height:  |  Size: 40 KiB

View File

@@ -76,8 +76,8 @@
</td>
</tr>
<tr>
<td><strong>Boot</strong> (Order: 1st-last)</td>
<td>{$vm_config['boot']}</td>
<td><strong>Boot Order</strong> (1st > 2nd)</td>
<td>{($vm_config['boot']|replace:'order=':''|replace:';':' > ')}</td>
</tr>
<tr>
<td><strong>IPv4</strong> (Networking)</td><td><strong>{$vm_config['ipv4']}</strong><br/>Mask:&nbsp;{$vm_config['netmask4']}<br/>Gateway:&nbsp;{$vm_config['gateway4']}</td>

View File

@@ -71,7 +71,7 @@ setrawcookie('PVEAuthCookie', $pveticket, [
// Build final noVNC URL
// ---------------------------------------
$hostname = gethostbyaddr($host);
$redirect_url = '/modules/servers/pvewhmcs/novnc/vnc.html?autoconnect=true&encrypt=true'
$redirect_url = './novnc/vnc.html?autoconnect=true&encrypt=true'
. '&host=' . $hostname
. '&port=8006'
. '&password=' . urlencode($vncticket)