From 0a790074e3f441c8d466e3a83cccc967bd2d2f1d Mon Sep 17 00:00:00 2001
From: Luke S Thompson <lst@luke.st>
Date: Fri, 1 Aug 2025 14:19:02 +1000
Subject: [PATCH] revert: version comparison (#62) v1.2.9.1

---
 README.md                            | 3 +--
 modules/addons/pvewhmcs/pvewhmcs.php | 6 +++---
 version                              | 2 +-
 3 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/README.md b/README.md
index 20a12ac..425f32e 100644
--- a/README.md
+++ b/README.md
@@ -34,7 +34,6 @@ We're pretty much done overhauling the Module to suit our needs at The Network C
 # 🎯 MODULE: System Requirements (PVE/WHMCS)
 
 - **(WHMCS)** v8.x.x stable (HTTPS)
-- **(WHMCS)** **Service ID above 100**
 - **(NET)** WAN Access: WHMCS to PVE
 - **(VNC)** Special Requirements: PTR, etc.
 - **(PHP)** v8.x.x (latest stable version)
@@ -57,7 +56,7 @@ Check the System Requirements above, and resolve any blockers to using Proxmox V
 
 **You must have a root account to use the Module at all.** Configured via WHMCS > Servers.
 
-This is configured in the pam realm. We plan to allow selection in v1.2.9.
+This is configured in the pam realm. We plan to allow selection in v1.3.x.
 
 #### Credentials: VNC user for Console Access only
 
diff --git a/modules/addons/pvewhmcs/pvewhmcs.php b/modules/addons/pvewhmcs/pvewhmcs.php
index 187b436..8d54093 100644
--- a/modules/addons/pvewhmcs/pvewhmcs.php
+++ b/modules/addons/pvewhmcs/pvewhmcs.php
@@ -36,7 +36,7 @@ function pvewhmcs_config() {
 	$configarray = array(
 		"name" => "Proxmox VE for WHMCS",
 		"description" => "Proxmox VE (Virtual Environment) & WHMCS, integrated & open-source! Provisioning & Management of VMs/CTs.".is_pvewhmcs_outdated(),
-		"version" => "1.2.9",
+		"version" => "1.2.9.1",
 		"author" => "The Network Crew Pty Ltd",
 		'language' => 'English'
 	);
@@ -45,7 +45,7 @@ function pvewhmcs_config() {
 
 // VERSION: also stored in repo/version (for update-available checker)
 function pvewhmcs_version(){
-	return "1.2.9";
+	return "1.2.9.1";
 }
 
 // WHMCS MODULE: ACTIVATION of the ADDON MODULE
@@ -89,7 +89,7 @@ function pvewhmcs_upgrade($vars) {
 	// This function gets passed the old ver once post-update, hence lt check
 	$currentlyInstalledVersion = $vars['version'];
 	// SQL Operations for v1.2.9 version
-	if ($currentlyInstalledVersion < 1.2.9) {
+	if (version_compare($currentlyInstalledVersion, '1.2.9', '<')) {
 		$schema = Capsule::schema();
 
 		// Add the column "start_vmid" to the mod_pvewhmcs table
diff --git a/version b/version
index 434dcac..f072199 100644
--- a/version
+++ b/version
@@ -1 +1 @@
-1.2.9
\ No newline at end of file
+1.2.9.1
\ No newline at end of file